Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added test case to verify registered protocol for IPv4 BFD peers #773

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

vitthalmagadum
Copy link
Contributor

@vitthalmagadum vitthalmagadum commented Aug 1, 2024

Description

All neighbor IPs where PEER_GROUP has BFD_ENABLED=true should be displayed with respective registered protocol(i.e ISIS or BGP etc)

Note: Added revision fix in VerifyBFDPeersIntervals, VerifyBFDSpecificPeers revision 1 as later revision introduces additional nesting for type

Fixes #766

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum changed the title feat(anta): Added registered protocol optional check to VerifyBFDSpecificPeers test case feat(anta): Added test case to verify registered protocol for IPv4 BFD peers Aug 12, 2024
@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 12, 2024 12:50
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
anta/tests/bfd.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 21, 2024

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I changed the result failure message to have the missing protocols instead.

@carl-baillargeon carl-baillargeon merged commit b9f95ae into aristanetworks:main Aug 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the test case to verify the BFD status, registered protocol.
2 participants